LGTM, other than the comment.

In general I'd prefer the formatting changes happening in a different commit, but it's no big deal.

Ha, I didn't even notice those. I run stylish-haskell and those changes just happened on save. I will back them out before the final commit.

Pinging @achernyak , how's it going?

@mgsloan Sorry for the long delay. Things got a bit crazy at work the last couple weeks. I plan to wrap everything up this weekend with all your suggestions and get this pushed out.

Sounds good! I'm just taking a look at all the open PRs!

I'll try to get #1674 merged first, as otherwise we may need to resolve some tricky merge conflicts.

@mgsloan I rebased the branch to get rid of some of the big style changes present before.

Also, now a list of directories can be passed in.

Hey, sorry for the review delay. Are you sure this works? To me it looks like it invokes init on each of the subdirectories, which isn't what we want.

No problem at all. I must have miss understood the exact ask here. I see two other options:

1. It only takes one subdirectory to search and runs init on it.
2. It searches each of the subdirectories for a .cabal file and only runs init on the directories that have a .cabal file. In this scenario not sure if it should search all subdirectories of those directories too.

Let me know which is more aligned with what is expected.

I think the main thing is that we only want to generate one stack.yaml, and so should only call initProject once.

It searches each of the subdirectories for a .cabal file and only runs init on the directories that have a .cabal file. In this scenario not sure if it should search all subdirectories of those directories too.

Right here, we want to search in the directories listed by the user. Searching in all subdirectories is controlled by includSubdirs

Got it, so we are only searching the specified directories and ignoring the subdirectories of the provided directories. Then we run initProject on the first .cabal file we find.

Well, we're trying to get a list of all the cabal files in the project cabalfps. Then, initProject tries to figure out a configuration that can build them all together.

I guess you don't need to change initCmd at all. Just extract the list of directories passed by the user inside initProject, use findCabalFiles on all of them (currently we use it only on CurrDir) and concat the result. The rest should be taken care of by the existing code. It should create a stack.yaml with all the packages in the specified directories.

@harendra-kumar Thanks, that makes complete sense. Realy cleared up my understanding on this one.

Just tested and I think this version should meet the behaviour described by @harendra-kumar.

Sorry, I missed the update to path-io so I ran into some conflicts I didn't notice until after the push. It is all fixed now.

Functionally it looks good. I added a few minor comments. Can you address those and squash the changes into a single commit?

Unrelated formatting changes are better done via separate commits. Though its fine for this one.

@harendra-kumar Thanks for the detailed review, working on those changes now.

I really need to turn off my stylish-haskell when working on stack. It's the issue where all the style changes are coming from, just auto formatting.